Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable source-map option in CSS build #444

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Enable source-map option in CSS build #444

merged 1 commit into from
Jul 13, 2023

Conversation

mosharaf13
Copy link
Contributor

close #414

What happened 👀

  • Enable source map when running css production build yarn build:css

Insight 📝

  • Generate source map with absolute path

Proof Of Work 📹

Screen Shot 2023-07-13 at 2 34 28 PM

Screen Shot 2023-07-13 at 2 34 57 PM

@mosharaf13 mosharaf13 self-assigned this Jul 13, 2023
malparty
malparty approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@malparty malparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

tyrro
tyrro approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@tyrro tyrro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in a local project, the browser is successfully able to point to the original source 👍🏿

Previously Now
Screenshot 2023-07-13 at 5 02 53 PM Screenshot 2023-07-13 at 5 01 00 PM

@malparty malparty added this pull request to the merge queue Jul 13, 2023
Merged via the queue into develop with commit c21e356 Jul 13, 2023
@malparty malparty deleted the feature/gh414-enable-source-map-in-css-build branch July 13, 2023 11:12
@malparty malparty added this to the 5.7.0 milestone Jul 26, 2023
@malparty malparty mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyduong1920 andyduong1920 andyduong1920 approved these changes

@tyrro tyrro tyrro approved these changes

@malparty malparty malparty approved these changes

@rosle rosle Awaiting requested review from rosle

@bterone bterone Awaiting requested review from bterone bterone is a code owner

@byhbt byhbt Awaiting requested review from byhbt byhbt is a code owner

@carryall carryall Awaiting requested review from carryall carryall is a code owner

@hoangmirs hoangmirs Awaiting requested review from hoangmirs hoangmirs is a code owner

@longnd longnd Awaiting requested review from longnd longnd is a code owner

@sanG-github sanG-github Awaiting requested review from sanG-github sanG-github is a code owner

Assignees

@mosharaf13 mosharaf13

Labels
type : feature
Projects
None yet
Milestone
5.7.0
Development

Successfully merging this pull request may close these issues.

Enable source-map option in CSS build
4 participants
@mosharaf13 @andyduong1920 @tyrro @malparty