Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#456] Fix setting Chrome's locale to non-English will cause some Capybara tests to fail #457

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

ghost
Copy link

@ghost ghost commented Aug 4, 2023

close #456

What happened 👀

Capybara tries to run the UI tests on different locale than our test suite causing a problem looking up some elements which contain localized string.

Insight 📝

  • Capybara should not inherit the page locale from the local web browser locale and instead always use English.

Proof Of Work 📹

All tests passed.

@andyduong1920
Copy link
Member

@topnimble I think you need to assign this PR to yourself, not to Xavier 🤞

@ghost
Copy link
Author

ghost commented Aug 7, 2023

@topnimble I think you need to assign this PR to yourself, not to Xavier 🤞

Xavier was the person who actually wrote this patch so it would be better to assign his name instead of me 👍.

@malparty malparty assigned ghost and unassigned malparty Aug 7, 2023
Copy link
Member

@malparty malparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@malparty
Copy link
Member

malparty commented Aug 7, 2023

@topnimble I think you need to assign this PR to yourself, not to Xavier 🤞

Xavier was the person who actually wrote this patch so it would be better to assign his name instead of me 👍.

You owned it: Not only you were the one to face the issue on your machine, but you took time to write the issue and prepare this PR 💪
Thanks for the intention though, I appreciate it 😇

@malparty malparty added this to the 5.8.0 milestone Aug 7, 2023
@malparty malparty added this pull request to the merge queue Aug 7, 2023
Merged via the queue into develop with commit 2ef9533 Aug 7, 2023
@malparty malparty deleted the bug/456-fix-capybara-locale branch August 7, 2023 06:31
@malparty malparty mentioned this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Setting Chrome's locale to non-English will cause some Capybara tests to fail
3 participants