-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#446][Part3] Add OpenAPI to support creating API documentation with OpenAPI #466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this PR belongs to the OpenAPI addon, should we move all template files into that folder instead? And find a way to integrate it with other add-ons (Docker, GitHub)?
After discussion with Sang, OpenAPI might NOT be an add-on, but a "mandatory" part of the template, included in any of the variants (API & Web). I'll wait until later this week to confirm that with Su V. If it's the case, I would argue that it will help keep the template code simpler and easier to test :D |
@malparty @sanG-github It cannot be a compulsory add-on if no API is built. You can refer to the Gin templates: |
All right, then let's implement it so that it does not leak in a new project that does not select the add-on 🙇 |
d9bb64a
to
38a8e54
Compare
f4e635c
to
487aeb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a mock server, it should be an add-on (you can check gin-templates)
- For API variant, we should show a message to ask if the developer want to have a mock server
- For Web variant, if the developer add openapi add on, then we will ask to have a mock server
53d9777
to
c162277
Compare
afadbe6
to
98a64d9
Compare
0b6e3bc
to
a026cb2
Compare
c162277
to
e527a20
Compare
a026cb2
to
f423d95
Compare
e527a20
to
98d42ae
Compare
fa830b4
to
d20d1ae
Compare
@sanG-github last rebase needed :harold: |
7a73e42
to
1688599
Compare
close #446
What happened 👀
Dockerfile.mock
fly.toml
deploy_mock_server.yml
Insight 📝
Support
mock_server
add-on for the templates. This will help developers to deploy a mock server based on OpenAPI spec.Here is the checklist of #446 when this pull request is merged:
Proof Of Work 📹