[#489] Fix: Postcss not compatible with Node 16 #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malparty
force-pushed
the
bug/gh489-fix-postcss-not-compatible-node-16
branch
from
3dc8632 to
8e6a638
Compare
malparty
requested review from
aetheryna,
andyduong1920,
bterone,
byhbt,
carryall,
Goose97,
hoangmirs,
longnd,
vnntsu and
tyrro
as code owners
sanG-github
approved these changes
Dec 14, 2023
Nihisil
approved these changes
Dec 14, 2023
captainnimble
approved these changes
Dec 14, 2023
vnntsu
approved these changes
Dec 14, 2023
tyrro
approved these changes
Dec 14, 2023
| @@ -3,7 +3,6 @@ | |||
| "@nimblehq/stylelint-config-nimble" | |||
| ], | |||
| "rules": { | |||
| "no-eol-whitespace": true, | |||
There was a problem hiding this comment.
for future reference: We've updated Stylelint to v15 in this PR and this rule is deprecated on Stylelint v15
This was referenced Dec 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #489
What happened 👀
It's faster to just update the needed dependencies rather than locking the template with outdated dependencies (with the cascading effect this can have).
Insight 📝
stylelintto version 15 // version 16 raise an error)Stylelint also came with new errors and I had to remove the global functions calls in favor of namespaced one.
Proof Of Work 📹
The tests should now pass. No behavior changed. ✅