System Specs config improvement #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…latest flags `disable-dev-shm-usage` for Docker (as of Chrome 65)
andyduong1920
approved these changes
May 8, 2018
rosle
reviewed
May 8, 2018
shared/rspec/support/capybara.rb
Outdated
| require 'capybara/rspec' | ||
|
|
||
| # Give CI some extra time | ||
| CAPYBARA_TIMEOUT = ENV['TEST_CI_SERVER'] ? 60 : 30 |
There was a problem hiding this comment.
While checking the CI services, I notice that most of it have CI=true variable set. Not sure, should we use that variable for checking or not?
There was a problem hiding this comment.
Great idea. Will change to this variable 👍
…er to conform to the one existing on most CI providers
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened
The work started due to Chrome driver stability issues (in #51). Upon research and fixing the issues, I found a more complete and also more transparent way to configure Capybara for our projects.
This solution uses the new flag
disable-dev-shm-usageavailable since Chrome 65 (see info). Contrary to #51, it does not require to upgrade to Docker Compose 3.5 ot latest which helps in supporting more CI/CD providers.Insight
export CHROME_HEADLESS=false. Then reset it:unset CHROME_HEADLESS.