Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update database config #94

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Update database config #94

merged 1 commit into from
Apr 12, 2019

Conversation

rosle
Copy link
Contributor

@rosle rosle commented Apr 12, 2019

What happened

✅ Update database configurations

Insight

When running rake db:setup on local, it should create 2 databases for development and test. Currently it create only one.

Screen Shot 2562-04-12 at 11 41 25
Screen Shot 2562-04-12 at 12 52 54

The problem is in our env, we set

development:
  <<: *default
  DB_NAME: "#{app_name}_development"

test:
  <<: *default
  DB_NAME: "#{app_name}_test"

So when we run rake db:setup on local, it always get the <name>_development because we're on the development.

To fix, I move the suffix to database.yml instead.

Proof Of Work

After:
Screen Shot 2562-04-12 at 11 40 06
Screen Shot 2562-04-12 at 12 52 48

@rosle rosle added this to the 3.2.0 milestone Apr 12, 2019
@rosle rosle changed the title Update database config and remove Update database config Apr 12, 2019
@olivierobert olivierobert merged commit 2df8b72 into develop Apr 12, 2019
@olivierobert olivierobert deleted the chore/update-config branch April 12, 2019 07:50
@rosle rosle mentioned this pull request Apr 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivierobert olivierobert olivierobert approved these changes

Assignees
No one assigned
Labels
type : chore
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rosle @olivierobert