Replace chromedriver-helper with webdrivers #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea @rosle My only concern is with "The drivers will now be automatically downloaded or updated when you launch a browser through Selenium.". Especially on CI platform, would that mean that in each task it will download the latest version 🤔? Probably pinning version could be good. What do you think? |
|
@olivierobert For the versioning, we can pin the version. Right now I set it in the If we don't specify this, it will download the latest one 👍 |
andyduong1920
approved these changes
Apr 18, 2019
olivierobert
approved these changes
Apr 20, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened
✅ Replace
chromedriver-helperwithwebdriversInsight
Now
chromedriver-helperis deprecated and it is moved towebdrivers. On new Rails 6, it has been moved towebdriverstoo. See rails/rails#35732I know we haven't include the chromedriver-helper in our gemfile before. But maybe we should? So that we don't need to install
chromedriveron each machine that we've been working on.Proof Of Work
The system test is still runnable.
To update, we can set the version in
support/webdrivers.rbThe webdriver is installed at
~/.webdriverby default. After update the version in the config and run the spec again, it should update the installed binary.