Skip to content
This repository has been archived by the owner on Jan 24, 2025. It is now read-only.

Add websockets #565

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add websockets #565

wants to merge 1 commit into from

Conversation

brantje
Copy link

@brantje brantje commented Aug 3, 2020

Pull request checklist

  • All tests pass. Demo project builds and runs.
  • I have resolved any merge conflicts.

This fixes issue #___.

What's in this pull request?

  • Add websocket rpc server
  • Add websocket events for blockchain and mempool events

@mar-v-in
Copy link
Collaborator

Hey @brantje,
Great that you are looking into this.

A few suggestions from my end:

  • Please make use of the newer Client API instead of directly calling into consensus objects.
  • Events should not be subscribed just because the websocket connection is opened. Instead subscription should happen through a json rpc command itself. The commands could match to the listener commands in Client API.
  • Events should make use of JSON-RPC notifications (as described in §4.1 of the JSON-RPC specification)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants