Skip to content

Commit

Permalink
Fix reward inherent hashes
Browse files Browse the repository at this point in the history
The wrong hash function was used, instead `tx_hash` is correct.

Fixes #2408.
  • Loading branch information
hrxi authored and jsdanielh committed May 17, 2024
1 parent 72c1abc commit d1e17ef
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions rpc-interface/src/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -653,21 +653,20 @@ pub enum Inherent {

impl Inherent {
pub fn try_from(hist_tx: HistoricTransaction) -> Option<Self> {
let hash = hist_tx.data.hash();
Some(match hist_tx.data {
HistoricTransactionData::Basic(_) => return None,
HistoricTransactionData::Equivocation(_) => return None,
HistoricTransactionData::Reward(RewardEvent {
validator_address,
reward_address,
ref validator_address,
ref reward_address,
value,
}) => Inherent::Reward {
block_number: hist_tx.block_number,
block_time: hist_tx.block_time,
validator_address,
target: reward_address,
validator_address: validator_address.clone(),
target: reward_address.clone(),
value,
hash,
hash: hist_tx.tx_hash().into(),
},
HistoricTransactionData::Penalize(PenalizeEvent {
validator_address,
Expand Down

0 comments on commit d1e17ef

Please sign in to comment.