Check that the peer sends us a body exactly when we ask for it #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdanielh
reviewed
Mar 6, 2024
| self.report_validation_result( | ||
| pubsub_id, | ||
| if info.on_main_chain { | ||
| MsgAcceptance::Accept |
There was a problem hiding this comment.
To me if the block is already known, we should use Ignore: Gossipsub is not supposed to send duplicate messages and an Accept will forward the message.
There was a problem hiding this comment.
I think gossipsub deduplicates the message already. Since this is the first time that we see this message in gossipsub, we should probably forward it, even if we got it by other means. … I'd think, at least.
There was a problem hiding this comment.
Ok, I see your point. Let's use accept then
jsdanielh
approved these changes
May 16, 2024
jsdanielh
force-pushed
the
hrxi/block_bodies
branch
from
ae5a5ba to
c3f939d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably helps with #2289.
Also validate gossipsub messages for blocks we already know.