Don't default-initialize RPC Transaction type
#2470
Conversation
|
I'd expect the |
Instead, try to find a sensible value for each field. Previously, the hash was zero-initialized, for example. Fixes #2465.
jsdanielh
force-pushed
the
hrxi/rpc_reward_tx_hash
branch
from
c7cbfdc to
397c7fe
Compare
| block_number: Some(macro_block.block_number()), | ||
| timestamp: Some(macro_block.timestamp()), | ||
| confirmations: cur_block_height.map(|h| h - macro_block.block_number()), | ||
| from: Address::default(), |
There was a problem hiding this comment.
I missed this in the review, but you changed the sender from the Policy::COINBASE_ADDRESS to Address::default(), which are different addresses.
There was a problem hiding this comment.
I should have alerted you to this, sorry. Is there a reason to prefer the all-zeros address over the coinbase address? As far as I understood it, the COINBASE address is the one where new coins come from?
There was a problem hiding this comment.
I don't understand the question, did you switch the address names in your second sentence?
This code here is converting reward inherents into transactions, so of course the tx should have the coinbase as sender.
There was a problem hiding this comment.
Actually, I just found this:
Can't we use that method here?
There was a problem hiding this comment.
Woops, you changed it back to COINBASE because I accidentally changed it to the all-zeros address. I got confused. Thanks for fixing it.
It was changed to the wrong address in #2470.
Instead, try to find a sensible value for each field. Previously, the hash was zero-initialized, for example.
Fixes #2465.