Get rid of HistoricTransaction::into_transaction
#2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did the method lose any other details, too? |
sisou
reviewed
May 27, 2024
ii-cruz
reviewed
May 28, 2024
ii-cruz
approved these changes
May 28, 2024
styppo
force-pushed
the
hrxi/fix_reward_hashes
branch
from
61b503d to
9d7cbb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was lossy, among others, it lost the actual transaction hash.
Instead, move the generation of transactions to the places where the hash can also be captured.
Fixes #2514.