Remove duplicate function between the blockchains #2534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viquezclaudio
force-pushed
the
viquezcl/duplicates
branch
2 times, most recently
from
5a80f0b to
c97abcf
Compare
sisou
reviewed
May 28, 2024
light-blockchain/src/blockchain.rs
Outdated
| @@ -101,7 +100,7 @@ impl LightBlockchain { | |||
| } | |||
| } | |||
|
|
|||
| // FIXME Duplicated function (also exists in full blockchain) | |||
| // A similar function exists in full blockchain, however the light blockcahin does not use any database txn. | |||
There was a problem hiding this comment.
Suggested change
| // A similar function exists in full blockchain, however the light blockcahin does not use any database txn. | |
| // A similar function exists in full blockchain, however the light blockchain does not use any database txn. |
jsdanielh
reviewed
May 28, 2024
viquezclaudio
force-pushed
the
viquezcl/duplicates
branch
from
c97abcf to
9e3c822
Compare
jsdanielh
approved these changes
May 28, 2024
jsdanielh
force-pushed
the
viquezcl/duplicates
branch
from
9e3c822 to
471578f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2527.
Pull request checklist
clippyandrustfmtwarnings.