Fix "cache state must exist" panic in validator-network
#2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrxi
force-pushed
the
hrxi/validator_peer_id_cache_unreachable
branch
from
b46f94d to
91987f3
Compare
|
I verified the panic was gone with this fix |
Fixes #2546. Previously, an entry of type `CacheState::InProgress(..)` would get dropped when setting new validator keys. This must not happen since the resolving thread expects to find that once it's done.
jsdanielh
force-pushed
the
hrxi/validator_peer_id_cache_unreachable
branch
from
91987f3 to
14c8528
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2546.
Previously, an entry of type
CacheState::InProgress(..)would get dropped when setting new validator keys. This must not happen since the resolving thread expects to find that once it's done.