Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feature compilation for several crates #2597

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

jsdanielh
Copy link
Member

Fix feature compilation for:

  • lib without the zkp-prover feature enabled.
  • mempool without any feature enabled.
  • primitives with only the slot feature enabled.
  • utils without any feature enabled.
  • zkp-component without any feature enabled.

Pull request checklist

  • All tests pass. The project builds and runs.
  • I have resolved any merge conflicts.
  • I have resolved all clippy and rustfmt warnings.

@jsdanielh jsdanielh requested review from hrxi and viquezclaudio June 12, 2024 13:08
tbu-
tbu- approved these changes Jun 12, 2024
Copy link
Contributor

@hrxi hrxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Fix feature compilation for:
- `lib` without the `zkp-prover` feature enabled.
- `mempool` without any feature enabled.
- `primitives` with only the `slot` feature enabled.
- `utils` without any feature enabled.
- `zkp-component` without any feature enabled.
@hrxi hrxi force-pushed the jsdanielh/crate_features branch from 7136fdc to a7c8177 Compare June 12, 2024 14:01
@hrxi
Copy link
Contributor

hrxi commented Jun 12, 2024

Rebasing for merge.

@hrxi hrxi merged commit a7c8177 into albatross Jun 12, 2024
6 checks passed
@hrxi hrxi deleted the jsdanielh/crate_features branch June 12, 2024 14:29
@jsdanielh jsdanielh added this to the Nimiq PoS Mainnet milestone Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants