Only accept control transactions over the control transaction topic #2627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrxi
force-pushed
the
hrxi/ctrl_transaction
branch
2 times, most recently
from
72ad684 to
dc88d07
Compare
Eligioo
reviewed
Jun 17, 2024
| type Error = ControlTransactionError; | ||
|
|
||
| fn try_from(tx: Transaction) -> Result<ControlTransaction, ControlTransactionError> { | ||
| if tx.sender_type != AccountType::Staking && tx.recipient_type != AccountType::Staking { |
There was a problem hiding this comment.
Should we also check if the value is 0 here?
There was a problem hiding this comment.
We discussed this shortly, and the answer was yes. However, since that is a breaking change, it cannot go into the next (compatible) testnet release.
There was a problem hiding this comment.
Signaling transactions also have TransactionFlags::SIGNALING set, but AFAIK the combination of that flag and zero value is already checked in the transaction's internal validity and/or parser.
The parsed IncomingStakingTransactionData has a .is_signaling() method:
Eligioo
approved these changes
Jun 17, 2024
jsdanielh
approved these changes
Jun 17, 2024
hrxi
force-pushed
the
hrxi/ctrl_transaction
branch
3 times, most recently
from
0e81d31 to
c1d958d
Compare
Don't verify contributions whose contributors are a subset of the already verified contributors.
Bumps the minor-and-patch-updates group with 1 update: [derive_more](https://github.com/JelteF/derive_more). Updates `derive_more` from 0.99.17 to 0.99.18 - [Release notes](https://github.com/JelteF/derive_more/releases) - [Changelog](https://github.com/JelteF/derive_more/blob/v0.99.18/CHANGELOG.md) - [Commits](JelteF/derive_more@v0.99.17...v0.99.18) --- updated-dependencies: - dependency-name: derive_more dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch-updates ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5.4.0 to 6.0.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@ca052bb...c382f71) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Do this by using a wrapper that only accepts control transactions. Fixes #2614.
hrxi
force-pushed
the
hrxi/ctrl_transaction
branch
from
c1d958d to
ca3dc07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do this by using a wrapper that only accepts control transactions.
Fixes #2614.