transaction: Optimize MMR hash for HistoricTransaction
#2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrxi
force-pushed
the
jsdanielh/minor_fixes
branch
from
e1ebddd to
071dc44
Compare
nibhar
approved these changes
Jun 17, 2024
Optimize MMR hash for `HistoricTransaction` by removing unnecessary vector allocation and writing all the data directly to the hasher. Co-authored-by: hrxi <[email protected]>
It was missed because the serialization wasn't derived.
jsdanielh
force-pushed
the
jsdanielh/minor_fixes
branch
from
071dc44 to
06f2c21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize MMR hash for
HistoricTransactionby removing unnecessary vector allocation and writing all the data directly to the hasher.Pull request checklist
clippyandrustfmtwarnings.