Dont move incompatible peers to live sync too early. #2679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viquezclaudio
force-pushed
the
viquezcl/sync_fix
branch
2 times, most recently
from
b79d547 to
2630b3f
Compare
Eligioo
reviewed
Jun 25, 2024
viquezclaudio
force-pushed
the
viquezcl/sync_fix
branch
from
2630b3f to
2e8bc71
Compare
Eligioo
approved these changes
Jun 25, 2024
jsdanielh
approved these changes
Jun 25, 2024
If peers are classified as incompatible and moved to live sync before the validity sync is complete, this creates issues where missing blocks can be pushed from the state sync, even though, we cannot verify the history root yet. With this change, we first complete the validity sync and after that, we move the incompatible peers to live sync.
jsdanielh
force-pushed
the
viquezcl/sync_fix
branch
from
2e8bc71 to
5154c54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If peers are classified as incompatible and moved to live sync before the validity sync is complete, this creates issues where missing blocks can be pushed from the state sync, even though, we cannot verify the history root yet.
With this change, we first complete the validity sync and after that, we move the incompatible peers to live sync.
Fixes #2675
...
This fixes #2675 .
Pull request checklist
clippyandrustfmtwarnings.