Make vesting contract creation parsing more resilient #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrxi
force-pushed
the
hrxi/vesting_related_addresses
branch
from
e9d120b to
916aa0f
Compare
hrxi
force-pushed
the
hrxi/vesting_related_addresses
branch
from
916aa0f to
6b6fe8a
Compare
hrxi
force-pushed
the
hrxi/vesting_related_addresses
branch
from
6b6fe8a to
9af27cf
Compare
jsdanielh
reviewed
Jun 26, 2024
hrxi
force-pushed
the
hrxi/vesting_related_addresses
branch
from
9af27cf to
6294aae
Compare
jsdanielh
approved these changes
Jun 27, 2024
Less manual and less error-prone.
The method was incorrect and could not be corrected. Use `VestingCreationData::parse` instead. Fixes #2690.
jsdanielh
force-pushed
the
hrxi/vesting_related_addresses
branch
from
6294aae to
29afc4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
serdeto do it, but remove theDeserializeimpl because it was error-prone.Based on top of #2676, so this should wait until #2676 is approved.
Fixes #2690.