Use PoW memory cost for Argon2d KDF #2705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisou
added
the
pow-compatibility
Eligioo
reviewed
Jun 27, 2024
hrxi
approved these changes
Jun 27, 2024
sisou
force-pushed
the
soeren/argon2-kdf-pow-compat
branch
from
7509eb2 to
9ca2cad
Compare
hrxi
force-pushed
the
soeren/argon2-kdf-pow-compat
branch
from
9ca2cad to
9cec756
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But keep the updated cost for Argon2id.
This makes the function backward-compatible with the PoW JS library, to support decoding existing LoginFiles.
Partly reverses 9f8db32 (#2653) and changes it to be in the spirit of #2377, which meant to preserve backward-compatibility.