Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated code to be compliant with Zig 0.12 #3

Merged
merged 4 commits into from
May 1, 2024
Merged

Updated code to be compliant with Zig 0.12 #3

merged 4 commits into from
May 1, 2024

Conversation

7Zifle
Copy link

@7Zifle 7Zifle commented Apr 28, 2024

This pull request makes necessary changes to get the codebase compliant with Zig 0.12. The test.Dockerfile builds musl 1.2.4 because Alpine Linux is using musl 1.2.5 which is incompatible with Zig 0.12. I wasn't able to find a simpler way of getting musl 1.2.4 in the testing environment.

@fkollmann
Copy link
Contributor

Thanks for the PR! I just realized the new Zig 0.12 got released. Please give me a few days to work through the changes (both this PR and Zig).

PS: Saw your previous PR. GitHub will automatically update a PR, if you push new changes.
PPS: Actually musl-dev in Alpine 3.19 is v1.2.4 (https://pkgs.alpinelinux.org/package/v3.19/main/x86_64/musl-dev).

@7Zifle
Removed useless build of musl and updated examples
896d71c 
- Zig 0.12 package was moved from Alpine's Edge Testing to Edge
  Community
@7Zifle
Copy link
Author

7Zifle commented Apr 29, 2024

Thank you for following up on this. I've updated the test.Dockerfile so it no longer includes building musl. It appears the problem I was having with the docker unit tests was related to a dependency on clang. I also went ahead and updated the examples build.zig files. Just a heads up, The build.zon files are still using zzmq-v0.2.1-zig0.11

@7Zifle
Fixed errors in examples from Zig 0.12 update
6b827d4 
- Errors with `stopRunning` in dealer examples resolved
- Errors relating to signal handling in dealer examples resolved
@7Zifle
Copy link
Author

7Zifle commented Apr 29, 2024

I apologize for the number of commits in this update. While reading over the examples, I noticed that several standard library functions referenced have been either relocated or modified slightly.

@fkollmann fkollmann changed the base branch from main to pr3_stage May 1, 2024 12:30
@fkollmann
Copy link
Contributor

FYI, since the PR contains various aspects, I will merge it into a new pr3_stage branch and work out the details from there.

@fkollmann fkollmann merged commit 0b630f0 into nine-lives-later:pr3_stage May 1, 2024
1 check passed
fkollmann added a commit that referenced this pull request May 1, 2024
@fkollmann
Update to Zig 0.12
305b54d 
(examples are still wip)
See #3
Thanks to https://github.com/7Zifle for most of the work!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@7Zifle @fkollmann