forked from GoogleCloudPlatform/java-docs-samples
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New #1
Merged
Merged
New #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add gitignore for appengine helloworld sample
This moves the first example from: https://cloud.google.com/appengine/docs/java/appidentity/ to GitHub. I also add a simple unit test to at least make sure this code builds & runs. Since this sample just wraps: ApiProxy.getCurrentEnvironment() .getAttributes() .get("com.google.appengine.runtime.default_version_hostname")) there isn't really much more we can test in this example. I will move the other examples from that page over in later PRs.
Since many users may want to run with multiple projects/versions (dev, staging, prod) document how to deploy this sample without having to modify the application-web.xml file.
This flag seems to be ignored by the gcloud plugin and the Managed VMs environment creates a new version if one isn't provided, anyway.
Add an App Identity example.
This sample is copied almost exactly from https://cloud.google.com/appengine/docs/java/appidentity/#asserting_identity_to_google_apis I also add a servlet for the sample code so that it can be more easily demonstrated and manually tested.
The gcloud command was getting the project argument when I was passing it in as -Dgcloud_project. After changing to -Dgcloud.gcloud_project it now deploys to the project I specify there. I hadn't noticed this until I had modified my gcloud config and deployments started going to the wrong project.
Fix project parameter in App Identity README.
Also, fixes typo (two spaces by Bearer).
Google style expects valid HTML, so I added the missing title and character encoding tags. Also, attributes should use double quotes, not single quotes. https://google.github.io/styleguide/htmlcssguide.xml
Add App Identity example to assert identity to Google APIs.
Initial import of MVM/SparkJava/gcloud-java example
ninebank
added a commit
that referenced
this pull request
Jan 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.