Fix OTP-26+ warnings in test suites

ninenines · Mar 30, 2023 · 251e70b · 251e70b
1 parent 4958af5
commit 251e70b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 11 deletions.
diff --git a/test/metrics_SUITE.erl b/test/metrics_SUITE.erl
@@ -469,15 +469,15 @@ error_response(Config) ->
 			[{_, #{
 				spawn := ProcSpawn,
 				exit := ProcExit,
-				reason := {crash, _StackTrace}
+				reason := {crash, StackTrace}
 			}}] = maps:to_list(Procs),
 			true = ProcSpawn =< ProcExit,
 			%% Confirm other metadata are as expected.
 			#{
 				ref := _,
 				pid := From,
 				streamid := 1,
-				reason := {internal_error, {'EXIT', _Pid, {crash, _StackTrace}}, 'Stream process crashed.'},
+				reason := {internal_error, {'EXIT', _Pid, {crash, StackTrace}}, 'Stream process crashed.'},
 				req := #{},
 				informational := [],
 				user_data := #{}
@@ -526,15 +526,15 @@ error_response_after_reply(Config) ->
 			[{_, #{
 				spawn := ProcSpawn,
 				exit := ProcExit,
-				reason := {crash, _StackTrace}
+				reason := {crash, StackTrace}
 			}}] = maps:to_list(Procs),
 			true = ProcSpawn =< ProcExit,
 			%% Confirm other metadata are as expected.
 			#{
 				ref := _,
 				pid := From,
 				streamid := 1,
-				reason := {internal_error, {'EXIT', _Pid, {crash, _StackTrace}}, 'Stream process crashed.'},
+				reason := {internal_error, {'EXIT', _Pid, {crash, StackTrace}}, 'Stream process crashed.'},
 				req := #{},
 				informational := [],
 				user_data := #{}

diff --git a/test/tracer_SUITE.erl b/test/tracer_SUITE.erl
@@ -29,13 +29,8 @@ suite() ->
 %% We initialize trace patterns here. Appropriate would be in
 %% init_per_suite/1, but this works just as well.
 all() ->
-	case code:is_module_native(?MODULE) of
-		true ->
-			{skip, "The Cowboy tracer is not compatible with native code."};
-		false ->
-			cowboy_tracer_h:set_trace_patterns(),
-			cowboy_test:common_all()
-	end.
+	cowboy_tracer_h:set_trace_patterns(),
+	cowboy_test:common_all().
 
 %% We want tests for each group to execute sequentially
 %% because we need to modify the protocol options. Groups