fix issue revealed by tightening of c-go rules #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
G'day @laibulle . I am not in a position to fully regression test my changes right at the moment. If you can pull this branch and tell me if it this solves the problem for you, please let me know and I'll merge this branch back into master. I have tested it to the extent that I reproduced the problem with zwcli and then verified that this change avoids the issue. |
jonseymour
force-pushed
the
issue-4
branch
2 times, most recently
from
62c8441 to
8b2affa
Compare
jonseymour
changed the title
In go1.6, cgo rules regarding the passing of Go pointers to C libraries changed to prevent unsafe interactions with the Go garbage collector. We need to change so that we pass an indirect reference to the Go object to the c-runtime. This code has been tested to the extent that is required to address the particular panic reported with #4 However, a more extensive regression test has not yet been performed. Signed-off-by: Jon Seymour <[email protected]>
|
It seems to solve the problem. I can run go-openzwave with go 1.6 but for the moment I just called Configurator.Boot() so it is not a full test. Thanks |
Closed
|
Thanks @laibulle - let me know if you encounter any other issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In go1.6, cgo rules regarding the passing of Go pointers to C libraries
changed to prevent unsafe interactions with the Go garbage collector.
We need to change so that we pass an indirect reference to the Go object
to the c-runtime.
This code has been tested to the extent that required to address the
particular panic reported with #4
However, a more extensive regression test has not yet been performed.
Signed-off-by: Jon Seymour [email protected]