-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modernize obsplus packaging #259
Conversation
Hey @sboltz , While you are looking at ObsPlus, what do you think of these changes? |
I'm fine with these changes. The only thing, and this might be (probably was) user error on my part, is that for one of my personal projects I recently tried setting it up with the src/ folder and PyCharm got ten kinds of confused when trying to auto-import things for me. That being said, I initially installed the project wrong so it may have just been a whoops in my environment. |
I haven't had any issues with several projects I am working on that now follow this style. Maybe just deleting the Ok, I will wait until #260 gets merged, rebase, then merge this. Anything else we want to do before another minor release? After adding py11 support it would make sense to do a release sooner rather than later. |
Maybe. Using the library works fine, it was just trying to get it to auto import, from say, the utils module into another file in the project that would confuse it, so that seems like a plausible fix.
From: Derrick Chambers ***@***.***>
Sent: Friday, March 17, 2023 3:17 PM
To: niosh-mining/obsplus ***@***.***>
Cc: Boltz, M. Shawn (CDC/NIOSH/SMRD/MSB) ***@***.***>; Comment ***@***.***>
Subject: Re: [niosh-mining/obsplus] modernize obsplus packaging (PR #259)
... PyCharm got ten kinds of confused
I haven't had any issues with several projects I am working on that now follow this style. Maybe just deleting the .idea folder would do it?
—
Reply to this email directly, view it on GitHub<#259 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARQXFLVMIJBHQVKHHJ2LCKLW4TPG3ANCNFSM6AAAAAAVDJ4DT4>.
You are receiving this because you commented.Message ID: ***@***.******@***.***>>
|
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #259 +/- ##
==========================================
- Coverage 97.83% 96.58% -1.26%
==========================================
Files 39 44 +5
Lines 4673 4806 +133
Branches 669 675 +6
==========================================
+ Hits 4572 4642 +70
- Misses 44 108 +64
+ Partials 57 56 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This PR tries to bring obsplus into compliance with best packaging practices in 2023. Specifically: