Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-pydantic v2 release prep #266

Merged
merged 7 commits into from
Jul 21, 2023
Merged

pre-pydantic v2 release prep #266

merged 7 commits into from
Jul 21, 2023

Conversation

d-chambers
Copy link
Member

Preparing for a release which pins pydantic < 2 so all the installs everywhere aren't broken. Will work on a pydantic v2 release after. Motivated by #265.

@d-chambers
Copy link
Member Author

I updated some of the CI, mainly to do caching of conda environment and to use mamba. Also updating some of the version release workflow (to use build) and a few misc other things.

There was a test failure related to different precision timedeltas no longer being equal so I updated that test case as well.

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (8e231f4) 96.58% compared to head (c424307) 96.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
- Coverage   96.58%   96.57%   -0.02%     
==========================================
  Files          44       44              
  Lines        4806     4812       +6     
  Branches      675      676       +1     
==========================================
+ Hits         4642     4647       +5     
  Misses        108      108              
- Partials       56       57       +1     
Flag Coverage Δ
unittests 96.57% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/obsplus/bank/wavebank.py 96.84% <100.00%> (+0.01%) ⬆️
src/obsplus/utils/misc.py 98.36% <100.00%> (+0.01%) ⬆️
src/obsplus/utils/time.py 98.11% <100.00%> (-1.25%) ⬇️
src/obsplus/version.py 100.00% <100.00%> (+33.33%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@d-chambers d-chambers merged commit 9136a80 into master Jul 21, 2023
@d-chambers d-chambers deleted the pre_pydantic_v2 branch July 21, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants