-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Merge T2w images and coregister to T1w template #319
Conversation
d9a6306
to
3b63103
Compare
Codecov ReportBase: 70.29% // Head: 66.58% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #319 +/- ##
==========================================
- Coverage 70.29% 66.58% -3.71%
==========================================
Files 17 18 +1
Lines 1168 1185 +17
Branches 200 202 +2
==========================================
- Hits 821 789 -32
- Misses 284 338 +54
+ Partials 63 58 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
3b63103
to
4dced14
Compare
4dced14
to
e4fc3fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, now that we are double dipping with some workflows, it may be time to change the parameters/inputs/outputs to reflect this generalization
40f766a
to
56e79d7
Compare
…at where possible
56e79d7
to
b41116b
Compare
Tests verifying that this doesn't break for no T2w images, and I've rerun locally with T2 and gotten the same result. Merging. |
## Changes proposed in this pull request Integrates and connects up nipreps/smriprep#319. ## Documentation that should be reviewed * [x] Mention in docs
The approach taken here is to merge the T2w images in exactly the same way as T1w images (N4 -> mri_robust_template) and then bbregister. This is the approach taken by
recon-all
, and seems the safest way to do this without running brain extraction first. Therefore this is only available if FreeSurfer is run.Closes #69.
We could probably throw in #13 at the same time and pass the merged T2w image to FreeSurfer...