Add support for a custom seqinfo to extract from DICOMs any additional metadata desired for a heuristic#581

Merged

yarikoptic merged 18 commits intomasterfrom enh-custom-seqinfo

Feb 28, 2024

+121-7

Commits on Feb 28, 2024

ENH: custom_seqinfo - provide a way for heuristics to extract/add arbitrary value
yarikoptic
committed
TMP: just a demonstration on how custom_seqinfo could/should be used
yarikoptic
committed
fixup typing in dicoms.py
yarikoptic
committed
add custom_info to group_dicoms_into_seqinfos call in parser

bpinsard
authored and
yarikoptic
committed
fix test, custom_seqinfo has to be hashable

bpinsard
authored and
yarikoptic
committed
test data include messed-up dicoms with no affine

bpinsard
authored and
yarikoptic
committed
add a check for hashable custom_info, link to new doc section

bpinsard
authored and
yarikoptic
committed
Typo fix
yarikoptic
committed
Log exception (as error) if we fail to obtain affine in convertall
yarikoptic
committed
fix the order of args in the custom_seqinfo doc
yarikoptic
committed
ENH: custom_seqinfo - provide a way for heuristics to extract/add arbitrary value
yarikoptic
committed
change tostr -> tobytes for deprecation, add basic test

bpinsard
authored and
yarikoptic
committed
linting/typing

bpinsard
authored and
yarikoptic
committed
fix py3.11 typing import

bpinsard
authored and
yarikoptic
committed
run pre-commit magic!

bpinsard
authored and
yarikoptic
committed
Create convertall_custom.py as a demonstration for a derived heuristic with custom_seqinfo
yarikoptic
committed
Fix import in the test due to move + use str() since now tostring is gone
yarikoptic
committed
Provide types for custom_seqinfo but disable type checking in the test -- I think mypy has deficiency since we do use kwargs and thus should be ok
yarikoptic
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for a custom seqinfo to extract from DICOMs any additional metadata desired for a heuristic#581

Commits on Feb 28, 2024

ENH: custom_seqinfo - provide a way for heuristics to extract/add arbitrary value

TMP: just a demonstration on how custom_seqinfo could/should be used

fixup typing in dicoms.py

add custom_info to group_dicoms_into_seqinfos call in parser

fix test, custom_seqinfo has to be hashable

test data include messed-up dicoms with no affine

add a check for hashable custom_info, link to new doc section

Typo fix

Log exception (as error) if we fail to obtain affine in convertall

fix the order of args in the custom_seqinfo doc

ENH: custom_seqinfo - provide a way for heuristics to extract/add arbitrary value

change tostr -> tobytes for deprecation, add basic test

linting/typing

fix py3.11 typing import

run pre-commit magic!

Create convertall_custom.py as a demonstration for a derived heuristic with custom_seqinfo

Fix import in the test due to move + use str() since now tostring is gone

Provide types for custom_seqinfo but disable type checking in the test -- I think mypy has deficiency since we do use kwargs and thus should be ok