Add “throws” keyword #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanghyojun
reviewed
Jun 23, 2017
syntax/nirum.vim
Outdated
| @@ -1,5 +1,5 @@ | |||
| syn match NirumComment /#.*/ | |||
| syn match NirumKeyword /^\(record\|enum\|unboxed\|type\|union\|service\|import\)/ | |||
| syn match NirumKeyword /^\(record\|enum\|unboxed\|type\|union\|service\|import\|throws\)/ | |||
There was a problem hiding this comment.
throws는 라인의 시작에서 시작되는 키워드가아니라 sym match되는 그룹을 분리하는게 어떨까요?
kanghyojun
reviewed
Jun 23, 2017
| @@ -1,13 +1,15 @@ | |||
| syn match NirumComment /#.*/ | |||
| syn match NirumKeyword /^\(record\|enum\|unboxed\|type\|union\|service\|import\)/ | |||
| syn match NirumTypeDecl /^\(record\|enum\|unboxed\|type\|union\|service\|import\)/ | |||
| syn match NirumMethodKeyword /\<throws\>/ | |||
There was a problem hiding this comment.
정규식에서 <,>가 특별한 의미가 있나요? vim 특수 문법인가 했는데 검색해봐도 안나오는듯해서 여쭙니당
There was a problem hiding this comment.
파이썬 정규표현식의 \b 같은 겁니다. 단어의 바운더리에 매치됩니다. 예를 들어 athrowsb, a throwsb, athrows b 등에는 매치되지 않지만 a throws b, a throws, throws b, ) throws b 등에는 매치됩니다.
There was a problem hiding this comment.
vim에서 직접해보니 exact match? 같은느낌으로 동작하는거같은데 맞나요?
kanghyojun
approved these changes
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlight the keyword
throwsintroduced by nirum-lang/nirum#38 and nirum-lang/nirum#43.