Add classifiers field to package metadata #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlbread
force-pushed
the
add-classifier-to-metadata
branch
from
3202a66 to
4a165ce
Compare
kanghyojun
added
typ:enhance
dahlia
requested changes
May 12, 2018
CHANGES.md
Outdated
| @@ -175,6 +175,8 @@ To be released. | |||
| Under the hood, all generated `import`s are now aliased with a name prefixed | |||
| an underscore. | |||
|
|
|||
| - Add python classifier metadata field. [[#100]] | |||
There was a problem hiding this comment.
Please use the past tense, and change the first letter of “python” to the capital letter “P.”
There was a problem hiding this comment.
It would be better if it links this PR number as well.
earlbread
force-pushed
the
add-classifier-to-metadata
branch
from
4a165ce to
c348ade
Compare
dahlia
approved these changes
May 12, 2018
Codecov Report
@@ Coverage Diff @@
## master #269 +/- ##
==========================================
- Coverage 76.16% 76.14% -0.03%
==========================================
Files 33 33
Lines 2446 2452 +6
Branches 132 131 -1
==========================================
+ Hits 1863 1867 +4
- Misses 451 454 +3
+ Partials 132 131 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #100.