Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secular notebook cutoff for periodic fitting validity, and GNSS dict #66

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

rzinke
Copy link
Contributor

@rzinke rzinke commented Sep 25, 2024

A warning is now printed for periodic (annual and semi-annual) fits if timeseries is < 2 years, and the periodic functions are excluded if TS is < 18 months.

The GNSS data are now kept solely in dictionary form until the final validation step, instead of in multiple parallel lists, limiting the potential for bookkeeping mistakes in the code.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@katia-tymofyeyeva katia-tymofyeyeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approved!

@EJFielding EJFielding merged commit da247a6 into main Nov 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants