Skip to content

Commit

Permalink
assign a=false, not all=false (same effect but more appropriate)
Browse files Browse the repository at this point in the history
  • Loading branch information
nishanths committed Nov 27, 2022
1 parent ce99d58 commit d7f7df1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions common_go118.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func fromInterface(pass *analysis.Pass, intf *types.Interface, typeparam bool) (
r, a := fromType(pass, u.Term(i).Type(), typeparam)
for _, rr := range r {
if !sameBasicKind(rr.et.TypeName.Type()) {
all = false
a = false
break
}
}
Expand All @@ -74,7 +74,7 @@ func fromInterface(pass *analysis.Pass, intf *types.Interface, typeparam bool) (
r, a := fromNamed(pass, embed.(*types.Named), typeparam)
for _, rr := range r {
if !sameBasicKind(rr.et.TypeName.Type()) {
all = false
a = false
break
}
}
Expand Down
6 changes: 3 additions & 3 deletions exhaustive.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ The Go [language spec] does not provide an explicit definition for enums. For
the purpose of this analyzer, and by convention, an enum type is any named
type that:
1. has underlying type float, string, or integer (includes byte and
- has underlying type float, string, or integer (includes byte and
rune, which are aliases for uint8 and int32, respectively); and
2. has at least one constant of the type defined in the same scope.
- has at least one constant of the type defined in the same scope.
In the example below, Biome is an enum type. The 3 constants are its
In the example below, Biome is an enum type. The three constants are its
enum members.
package eco
Expand Down

0 comments on commit d7f7df1

Please sign in to comment.