Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent route for metadata creation across ETL rules #178

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

thomas-fred
Copy link
Contributor

@thomas-fred thomas-fred commented Sep 22, 2023

In the ETL process there are 3 rules which create metadata entries, each called something like POST_metadata_to_backend. 1 for ISIMIP, 1 for Aqueduct and 1 for every other dataset.

I had stripped out the leading /api from /api/tiles/sources for the dataset specific routes used to create metadata for the dataset specific routes for a particular configuration of services locally. This was useful if you wanted to direct the request at the backend service directly (say if there is no frontend). It is not ideal when creating metadata entries on a remote, where you are more likely to need to pass through a reverse proxy (which needs the /api for routing to the appropriate service).

Change to have /api/tiles/sources consistently as the route, and change documentation and env variable names to make clear you need a proxy of some kind. This allows ETL to interact with local and remote instances with only configuration changes.

@thomas-fred thomas-fred merged commit 7eae6f5 into master Sep 22, 2023
@thomas-fred thomas-fred deleted the fix/etl_metadata_creation_route_consistency branch September 22, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant