consistent route for metadata creation across ETL rules #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the ETL process there are 3 rules which create metadata entries, each called something like
POST_metadata_to_backend
. 1 for ISIMIP, 1 for Aqueduct and 1 for every other dataset.I had stripped out the leading
/api
from/api/tiles/sources
for the dataset specific routes used to create metadata for the dataset specific routes for a particular configuration of services locally. This was useful if you wanted to direct the request at thebackend
service directly (say if there is no frontend). It is not ideal when creating metadata entries on a remote, where you are more likely to need to pass through a reverse proxy (which needs the/api
for routing to the appropriate service).Change to have
/api/tiles/sources
consistently as the route, and change documentation and env variable names to make clear you need a proxy of some kind. This allows ETL to interact with local and remote instances with only configuration changes.