Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/backend install #185

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Fix/backend install #185

merged 5 commits into from
Nov 15, 2024

Conversation

tomalrussell
Copy link
Member

Mainly for the notes on installing a python environment:

pip install . installs the backend package as defined by the pyproject.toml, and checks for its dependencies and installs them if needed

pip install -e . does an editable install, so changes in the source python files are directly reflected in the environment without needed to reinstall (still need to restart the uvicorn server)

pip install -e .[dev] includes the "dev" group of optional dependencies.

@tomalrussell tomalrussell requested a review from mz8i November 14, 2024 15:01
Copy link
Contributor

@mz8i mz8i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work alright, so I'm assuming what I was doing wrong was running pip install . rather than pip install -e .[dev]...?

See just the one comment/question regarding docs and activate path, otherwise good to merge!

containers/backend/README.md Outdated Show resolved Hide resolved
@mz8i
Copy link
Contributor

mz8i commented Nov 15, 2024

Actually, I now checked again with pip install . and the dependencies also got installed, which is slightly surprising because they didn't before. I'm thinking maybe it was originally a problem with using some older version of pip that didn't support installing from pyproject.toml (even though I thought I'd checked for the right version).

In any case, the installation now works correctly when following the readme, which is most important!

@tomalrussell tomalrussell merged commit c95b7cd into master Nov 15, 2024
@tomalrussell tomalrussell deleted the fix/backend-install branch November 15, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants