Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for Mixpanel API changes #3

Closed
wants to merge 2 commits into from
Closed

Update for Mixpanel API changes #3

wants to merge 2 commits into from

Conversation

aonic
Copy link

@aonic aonic commented Dec 3, 2019

@nithincvpoyyil nithincvpoyyil added bug Something isn't working enhancement New feature or request labels Dec 4, 2019
@nithincvpoyyil
Copy link
Owner

nithincvpoyyil commented Dec 4, 2019 •
edited
Loading

@aonic : Thanks for your PR, could you please create this PR to develop branch.

@nithincvpoyyil
Copy link
Owner

nithincvpoyyil commented Dec 4, 2019 •
edited
Loading

Hi @aonic I'm not merging this PR directly, because, I have some other changes which will conflict with this, however, I have copied your codebase and added in my branch, also, added you as a contributor in the home page. The new version is now available in the web store version 0.3, please have a look. Thank you for support.

nithincvpoyyil
nithincvpoyyil requested changes Dec 4, 2019
View reviewed changes
Copy link
Owner

@nithincvpoyyil nithincvpoyyil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aonic I'm not merging this PR directly, because, I have some other changes which will conflict with this, however, I have copied your codebase and added in my branch, also, added you as a contributor in the home page. The new version is now available in the web store version 0.3, please have a look. Thank you for support.

@aonic aonic closed this Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nithincvpoyyil nithincvpoyyil nithincvpoyyil requested changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aonic @nithincvpoyyil