-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prerender): support for query links exploration #1474
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1474 +/- ##
==========================================
- Coverage 76.40% 76.10% -0.31%
==========================================
Files 73 73
Lines 7558 7570 +12
Branches 745 745
==========================================
- Hits 5775 5761 -14
- Misses 1782 1808 +26
Partials 1 1
|
pi0
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks β€οΈ
Thanks you a lot @pi0, great work done here. Will this fix be part of the next release? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#1473
β Type of change
π Description
What:The pre-renderer process now explore query links found on the page (without rendering them as this could cause problem for OS that don't support such chars in the file path)
Why:If for example posts links are present in paginated pages like https://example.com/posts?page=3, they will not be pre-rendered that could cause performance issues and also break some functionalities when modules rely on pre-rendering (such as sitemap)
Issue:Resolves #1473
π Checklist