forked from bitpay/bitcore
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet Import from file #2
Open
micahriggan
wants to merge
7
commits into
nitsujlangston:feature/walletUtils
Choose a base branch
from
micahriggan:feature/walletUtils-import
base: feature/walletUtils
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Wallet Import from file #2
micahriggan
wants to merge
7
commits into
nitsujlangston:feature/walletUtils
from
micahriggan:feature/walletUtils-import
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahriggan
commented
Apr 20, 2018
- Importing wallet addresses from jsonl file
- Broadcast as a wallet method, so you can have chain and network from the wallet
- Alternatively, we could pass in chain and network to the broadcast command
- Balance shows the network associated with the balance
- Removing debug lines from import
- Cleaning up some sections still using walletId
- Removing duplicate getWallet on route that is using authenticate middleware
…iggan/bitcore into micahriggan-feature/v8-bitcore-mnemonic
nitsujlangston
pushed a commit
that referenced
this pull request
Mar 28, 2019
merge from bitpay:master
nitsujlangston
pushed a commit
that referenced
this pull request
Dec 18, 2019
Add invoiceID to wallet-tx
nitsujlangston
pushed a commit
that referenced
this pull request
Apr 8, 2020
Fixing loadWallet to handle db down, and throw in loadWallet if no wa…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.