Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index.rs: Add db writeability check #34

Merged
merged 1 commit into from
Nov 20, 2022
Merged

Index.rs: Add db writeability check #34

merged 1 commit into from
Nov 20, 2022

Conversation

cyntheticfox
Copy link
Member

Add a writeability check to the is_database_old function in case the database is managed externally (such as being in the /nix/store directory).

Closes #33

Signed-off-by: David Houston [email protected]

lilyinstarlight
lilyinstarlight approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this PR locally and can confirm it behaves as intended, and that it does get rid of the warning message when the nix-index database is symlinked from the Nix store

@Artturin
Copy link
Member

Thanks

@Artturin Artturin merged commit 4ed30d5 into nix-community:master Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilyinstarlight lilyinstarlight lilyinstarlight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comma db age check runs on "modified" time
3 participants
@cyntheticfox @Artturin @lilyinstarlight