fix: avoid external probing effects from other devices

[blaggacao]

Context

partprobe without [DEVICE] probes all devices and thus those devices can have external effects.

One such external effect is, for example, the following error that had been observed when using a usb live stick device (potentially damaged or otherwise not entirely appropriatly set up).

Error: Partition(s) 1 on /dev/sda have been written, but we have been unable to inform the kernel of the change, probably because it/they are in use.  As a result, the old partition(s) will remain in use.  You should reboot now before making further changes.

Proposed Solution

• Strictly specify the [DEVICE] in scope where possible

Review Note

disko on  fix/external-effects-on-partprobe took 2m55s
❯ rg 'partprobe'
lib/make-disk-image.nix
21:    parted # for partprobe
46:    partprobe

lib/types/mdadm.nix
45:        partprobe /dev/md/${config.name}
78:        pkgs.parted # for partprobe

lib/types/table.nix
94:          partprobe ${config.device}
104:          partprobe ${config.device}

lib/types/gpt.nix
110:          partprobe ${config.device}
154:          pkgs.parted # for partprobe

lib/types/zfs_volume.nix
53:        partprobe /dev/zvol/${config._parent.name}/${config.name}
77:        pkgs.parted # for partprobe

lib/make-disk-image.nix seemed ambiguous, but I understand it's also "just" for VM tests and hence a controlled environment (i.e. no external effects).

[Lassulus]

@mergify queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 0faae8a