Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helix extraPackages packages should be able to be overwritten by a flake.nix/direnv #4750

Open
nyabinary opened this issue Dec 8, 2023 · 2 comments

Comments

@nyabinary
Copy link

nyabinary commented Dec 8, 2023

Description

Currently, if I have rust-analyzer specified in extraPackages but then I CD into a project that has a direnv flake.nix the extraPackages currently overrides the flake.nix, in my opinion the flake.nix should override the wrapper. For example, I have a Rust nightly project with a direnv (to install rust-analyzer nightly and rust nightly in general). But the extraPackages currently overrides the rust-analyzer with the stable version of rust-analyzer instead of the nightly version, like I want it to. This is pretty annoying since I have rust-analyzer in my extraPackages to support typical Rust or standalone Rust files that don't require the nightly version of rust-analyzer. Is there any way to make it, so the package is beneath the package specified in the flake.nix/direnv environment?

@Philipp-M

@Philipp-M
Copy link
Contributor

I don't think there's a satisfying solution for this currently.
So either override helix completely, or use a project specific languages.toml.

What you could do as well, is not adding rust-analyzer to the extraPackages, and instead using e.g. the global home.packages or environment.systemPackages, in that case it should use the current rust-analyzer in the PATH.

There's also an open issue, which should make this easier (config.toml/languages.toml via cli parameter): helix-editor/helix#7102 and helix-editor/helix#2135

Copy link

stale bot commented Mar 9, 2024

Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

  • If this is resolved, please consider closing it so that the maintainers know not to focus on this.
  • If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough.
  • If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

  • If you are also experiencing this issue, please add details of your situation to help with the debugging process.
  • If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

Don't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants