helix: change wrapping when adding extraPackages to suffix

[mrnossiom]

Description

This makes extraPackages the default, but they do not shadow the env.

So you can still have packages (e.g. LSPs) with a different version than the global one in you local env like nix's shells.

Checklist

• Change is backwards compatible.

  I guess this is not really backwards compatible but to me this is the expected behaviour. This PR is there to discuss my point.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

• Test cases updated/added. See example.

  I checked and it seems there is no test to update. I'm not sure adding a test is necessary.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

@Philipp-M

[Philipp-M]

LGTM

[nyabinary]

Does this fix #4750 ?

[mrnossiom]

I would say that yes, It does

[Philipp-M]

I don't have merge rights (and approved already), so maybe @rycee ?

[stale]

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

• GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
• If it is unfinished but you plan to finish it, please mark it as a draft.
• If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
• To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

• If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

[mrnossiom]

I just rebased. This is still ready to merge.

[rycee]

Thanks! Merged to master now 🙂