Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: add bumblebee-status #4474

Closed

Conversation

augustebaum
Copy link

Description

Add module programs.bumblebee-status, a status bar program for use with, e.g., i3.

Importantly, as the package has not yet been merged into nixpkgs, I had to add it manually to the test suite in order to test the module; hence the draft status. Ideally all that remains to be done when the nixpkgs PR is merged is to commit which adds the package.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

FIXME: This commit enables tests by by adding the `bumblebee-status`
derivation that has been submitted to `nixpkgs` (<NixOS/nixpkgs#254772>).
Hence this commit should be pruned at least when `bumblebee-status` is merged into `nixpkgs-unstable`.
Copy link

stale bot commented Dec 17, 2023

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

@stale stale bot added the status: stale label Dec 17, 2023
@augustebaum
Copy link
Author

Not using bumblebee-status anymore so I'm not motivated to finish this, but feel free to take a look!

@stale stale bot removed the status: stale label Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant