Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake-module: revert rename #6406

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

khaneliman
Copy link
Collaborator

@khaneliman khaneliman commented Feb 4, 2025

This reverts commit 066ba0c.

Description

Follow up to discussion #6392 (comment)

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@rycee @teto @MattSturgeon

…ix-community#6392)"

This reverts commit 066ba0c. After
further discussion, we want to maintain this as the naming scheme going
forward to be similar to standards that have been trying to be
implemented in naming configurations and modules.
@nyabinary
Copy link

I think homeManagerModules make more sense since it's more specific personally :3

@MattSturgeon
Copy link
Member

I'll attempt to summaries my arguments made in #6392:

IMO it is important that modules and configurations have a consistent output name.

Currently, homeConfigurations is well documented and is standardized by the home-manager CLI.

Additionally, these are also the names used by the somewhat established flake schemas repo, that may eventually get merged into nix (NixOS/nix#8892).

According to @teto, homeModules was also used in templates and/or less visible parts of documentation (prior to #5229).

The only strong argument I've seen against this is the module class name is currently "homeManager", and it is often convention for the class-name to correlate with the flake output name. However, surely this argument also applies to the configuration output name, is less user-facing, and something that could be addressed separately if needed.

I think homeManagerModules [is] more specific

IMO, if we go down this route, we'd also want to rename homneConfigurations -> homeManagerConfigurations, which is a much more significant change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants