Fix typo in xdg-user-dirs.

[mtreca]

Configuration key publishShare has been replaced by publicShare.

See #985

[vojta001]

Don't you have to change it on line 93 as well?

[mtreca]

@vojta001 You are correct. Fixed.

[teto]

this may break configs, not sure if we can alias the option or if it's worth it.

[mtreca]

@teto Is breaking config for incorrect configuration keys such a bad thing?
I am genuinely asking since I am quite new to the project.

I know I had to triple check when first setting up my XDG config since the typo is easily overlooked. so that's a cost for users as well.

[teto]

I think thats fine considering its a relatively new module but I prefer to wait for @rycee s approval

[rycee]

Thanks for the discovery and fix! I would suggest adding

imports = [
  (mkRenamedOptionModule
    [ "xdg" "userDirs" "publishShare" ]
    [ "xdg" "userDirs" "publicShare" ])
];

to the module, under the meta.maintainers line.

Then configurations using the old name will still work but a warning will be printed saying the name has changed. We can remove this mkRenamedOptionModule thing in the next release cycle.

[rycee]

Oh, also. The commit description should be changed to match the guidelines. Something like

xdg-user-dirs: fix typo in option name

Fixes #985

should be fine.

[mtreca]

@rycee Thank you for the feedback. I changed the commit message and added your suggestion.

[rycee]

Thanks! Rebased to master in c8323a0.