Switch to extended Nixpkg's lib
#994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rycee
force-pushed
the
extended-stdlib
branch
2 times, most recently
from
4486d10 to
10c445f
Compare
|
@infinisil I gave the |
|
Nice, another thing that might need changing here is the NixOS module. NixOS/nixpkgs#75031 introduced the submoduleWith {
modules = [ ... ];
specialArgs.lib = extendedLib;
# To be backwards compatible with `types.submodule`
shorthandOnlyDefinesConfig = true;
} |
rycee
force-pushed
the
extended-stdlib
branch
from
10c445f to
2a425fe
Compare
|
@infinisil Yep, that does indeed seem to work just fine! @kalbasit Are you using HM with nix-darwin master? If so, would you mind giving this branch a try to verify that it still works? |
rycee
force-pushed
the
extended-stdlib
branch
from
2a425fe to
6cdd19e
Compare
|
Ah and I just realized that |
|
@infinisil Yeah. I left the I suppose it could cause difficulties for somebody who, for some strange reason, made their own module having options named |
rycee
force-pushed
the
extended-stdlib
branch
from
6cdd19e to
8b26499
Compare
|
Added some release notes. Rendered: |
rycee
force-pushed
the
extended-stdlib
branch
2 times, most recently
from
241af0b to
f6dbcf0
Compare
I'm getting an error building with the latest nix-darwin master, along with this branch. I have not changed anything in my configuration. |
rycee
force-pushed
the
extended-stdlib
branch
from
f6dbcf0 to
4badef8
Compare
|
@kalbasit Thanks! I force-pushed an update that I hope fixes this error. |
This change makes use of the `extend` function inside `lib` to inject a new `hm` field containing the Home Manager library functions. This simplifies use of the Home Manager library in the modules and reduces the risk of accidental infinite recursion. PR #994
|
It seems to build fine now. I switched the system and things are looking the same as well. |
|
@kalbasit Brilliant, I'll merge. |
rycee
force-pushed
the
extended-stdlib
branch
from
4badef8 to
6e4b9af
Compare
jorsn
pushed a commit
to jorsn/home-manager
that referenced
this pull request
Apr 25, 2020
This change makes use of the `extend` function inside `lib` to inject a new `hm` field containing the Home Manager library functions. This simplifies use of the Home Manager library in the modules and reduces the risk of accidental infinite recursion. PR nix-community#994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes use of the
extendfunction insidelibto inject a newhmfield containing the Home Manager library functions. This simplifies use of the Home Manager library in the modules and reduces the risk of accidental infinite recursion.