drv: backport CA derivations support changes from hydra-eval-jobs #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not possible to query output paths for CA derivations since they're not static / known at eval time. Instead, return JSON nulls for outputs paths. This is a partial port of the following Hydra commits: - 9ba4417940ffdd0fadea43f68c61ef948a4b8d39 - 069b7775c565f5999fe33e8c3f28c7b9306039ca - fcde5908d8e51f975b883329b34d24a9f30ea4b3 By the following authors: Co-Authored-By: John Ericson <[email protected]> Co-Authored-By: Théophane Hufschmitt <[email protected]> Co-Authored-By: Alexander Sosedkin <[email protected]> Co-Authored-By: Andrea Ciceri <[email protected]> Co-Authored-By: Charlotte 🦝 Delenk [email protected]> Co-Authored-By: Sandro Jäckel <[email protected]>
Mic92
force-pushed
the
fix-ca-derivations
branch
from
168bc7a to
bc4f360
Compare
Yes, this seems to be all that is needed. |
|
Okay, once I have better internet, I want to test this with the content-addressing turned on. |
|
Finally tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not possible to query output paths for CA derivations since they're not static / known at eval time. Instead, return JSON nulls for outputs paths.
This is a partial port of the following Hydra commits:
cc @zowoq (I believe this is the change needed for hydra)