nix 2.25 #339
nix 2.25 #339
Conversation
Mic92
force-pushed
the
nix-upgrade
branch
4 times, most recently
from
8033006 to
a4921ad
Compare
|
N.B., I think it would be prudent to get Hydra using |
| // we need this include or otherwise we cannot instantiate std::optional | ||
| #include <nlohmann/json.hpp> //NOLINT(misc-include-cleaner) |
There was a problem hiding this comment.
Do we need to do this in drv.hh or drv.cc? I would think just the latter
There was a problem hiding this comment.
If I drop it, clang-tidy gets really unhappy:
error: implicit instantiation of undefined template 'nlohmann::basic_json<>' [clang-diagnostic-error]
This is using
ninja clang-tidy
There was a problem hiding this comment.
Oh, for Drv::meta, and implicit constructors
|
I branched out https://github.com/nix-community/nix-eval-jobs/tree/release-2.24 for future nix 2.24 backports for hydra. |
Mic92
force-pushed
the
nix-upgrade
branch
3 times, most recently
from
bdf0778 to
1a612fb
Compare
Mic92
force-pushed
the
nix-upgrade
branch
2 times, most recently
from
b8e93e7 to
61a970a
Compare
|
@mergify queue |
☑️ The pull request will automatically be requeuedMerge queue reset: an external action moved the base branch head to b29bf47 |
No description provided.