Release 21.11 #147

Gerschtli · 2021-12-05T15:31:48Z

I prepared the release for 21.11, but for updating nixpkgs version there was an error because pkgs/top-level/static.nix was removed in NixOS/nixpkgs@3edba5e. I do not know that much about this cross-compiling stuff, will have a look at it but I am not sure if I am able to solve this.

t184256 · 2021-12-05T15:34:21Z

Awesome, I'll definitely have a look next week!

t184256 · 2021-12-06T17:40:47Z

Got a minute to look at it. NixOS/nix@5740924#diff-112352307fc4c615843e2a683ed2dd10d73556e1c32932e0545270317d8fbe31 seems to turn pthreads initialization from warning to an error, breaking db initialization inside nix-directory.

But, this made me wonder, was it really necessary to use the target nix for it? Could we instead proot -b-mount pkgsStatic.nix someplace into the nix-directory building environment and use that to init? If yes, we're trading the hackily pulled in qemu-user binary for a pkgsStatic.nix.

I'll try that today or tomorrow if you don't get to it first.

Workaround is with home-manager 21.11 no longer needed.

t184256 · 2021-12-08T22:35:51Z

there was an error because pkgs/top-level/static.nix was removed in NixOS/nixpkgs@3edba5e

I believe it was an overlay of hacks to make stuff link statically, not having it is not alarming.

I do not know that much about this cross-compiling stuff, will have a look at it but I am not sure if I am able to solve this.

It sure looks like you've succeeded =)

t184256 · 2021-12-08T23:57:17Z

OK, today I'm stopping at experimental Nix feature 'nix-command' is disabled during bootstrap; most likely nix build in login inner meets one of the Nix 2.4 breakages.

Gerschtli · 2021-12-09T16:24:04Z

Oh right, because also the nix-on-droid script uses the new nix command, this feature should be enabled per default.

Gerschtli · 2021-12-09T19:42:12Z

I think the main question is: Do we want to use nix 2.4 as default or stick with nix 2.3 as nixpkgs-stable defaults to. Maybe it would be easier to keep it at nix 2.3 for now and document (or implement it by default) that experimental-features = nix-command needs to be enabled.

t184256 · 2021-12-09T19:44:35Z

Oh, so they did revert it in the end? If so, then it makes sense to follow suite.

Gerschtli · 2021-12-09T19:59:29Z

Yes, so I removed the nix update but added support if someone wants to enable nix 2.4 so that nix-on-droid script still works.

t184256 · 2021-12-09T21:06:52Z

Installs fine now. My next steps are, I guess, a rebase of the tests PR on top of this, testing and careful reading. Got any more plans for the release?

Gerschtli · 2021-12-09T21:11:04Z

No, that would be all for this PR.

Gerschtli · 2021-12-09T21:12:14Z

Maybe adding a test for nix 2.4 with non flake setup would be worth it if you are on it.

Gerschtli · 2021-12-09T22:25:11Z

One thing came to my mind: Maybe this would be a good opportunity to get rid of these assertions in the home-manager module, asserting a newer version of nixpkgs and home-manager than 19.09.

t184256 · 2021-12-10T19:50:35Z

modules/environment/nix.nix

@@ -75,6 +91,7 @@ in
        "cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY="
        "nix-on-droid.cachix.org-1:56snoMJTXmDRC1Ei24CmKoUqvHJ9XCp+nidK7qkMQrU="
      ];
+      experimentalFeatures = mkIf (versionAtLeast cfg.package.version "2.4") [ "nix-command" ];


https://nixos.org/manual/nix/stable/command-ref/conf-file.html says it's enabled by default in stable (2.4), do we still need to worry about it?

or is this exactly why we have to worry about it? =)

Fun fact: Yesterday the default was 0, I wondered what that meant.. Seemed to be a bug in the documentation :D Then we definitely do not need this, I will remove it.

See NixOS/nixpkgs#149791.

modules/environment/login/nix-on-droid.nix.default

This allows evaluation of configurations where nixpkgs.* options are used even when in a flake setup with unchanged default values.

t184256

I believe it's fine. Thanks for your work, much appreciated!

Gerschtli · 2021-12-12T17:19:35Z

Please do not forget to push the new bootstrap to https://nix-on-droid.unboiled.info/ :)

And the default zipball location in the android app should not point to 20.09. Should we write a short file to document all manual steps for a release? Looks like a lot of things to think about.

Gerschtli · 2021-12-14T21:36:44Z

In case you didn't see my comment, ping @t184256 :)

t184256 · 2021-12-14T21:49:19Z

I do remember, I haven't actually tagged 21.11 yet. I planned to also pick up #150, #153 maybe, some assorted fixes to README and dropping i686. And if you plan any more exciting stuff, please warn me, I like our current practice of big releases and backporting basically never.

Gerschtli · 2021-12-14T22:05:49Z

Just to be clear, we never tag and only create branches for the release from that commit where we drop support for the old nixpkgs and home-manager releases, at least that was my understanding. So I think branching release-21.11 off starting with b30833b (removal of make workaround -> breaking change) would be a good idea.

Wait, I just noticed that our branches are a bit confusing :D So currently after releasing the version, the release branch does not get any updates? This forces every user to follow master if they want updates more often than the nixpkgs releases. Didn't realise that until now. It works for the current (I would estimate) small user base of nix-on-droid, but maybe it needs some refinement in the future.

So either way, let's stay with the release idea.

I like the idea to drop i686, reduces development overhead. I think we could give the changelog a bit more love, but other than that I think the release looks complete.

How do you think about keeping track and gathering bigger things we want to accomplish? I saw that github has some kind of a ticket board (trello like), or maybe we use the discussions for that. Because sometimes I have so many ideas and want to write them down somewhere, I think that would help sync ourselves to common goals or to plan things better.

BTW: I love working on this project with you, always makes a lot of fun to see what we creating here :)

t184256 · 2021-12-14T22:32:54Z

Just to be clear, we never tag and only create branches for the release

True; wrong term; my bad. I meant that I like our branches mostly-immovable (and mostly-fast-forwarding-when-we-do-move-them).

from that commit where we drop support for the old nixpkgs and home-manager releases, at least that was my understanding

I didn't know we had a system =) Mine was way less defined: "release preparation activity dies down, I create the branch and update app".

the release branch does not get any updates?

I think we sometimes merge --ff-only really innocent things, but when the first major thing lands, the branch stops advancing and we tell people to use master.

This forces every user to follow master if they want updates more often than the nixpkgs releases. Didn't realise that until now. It works for the current (I would estimate) small user base of nix-on-droid, but maybe it needs some refinement in the future.

I'd say it works for our model of dropping big changes around nixpkgs release time.

How do you think about keeping track and gathering bigger things we want to accomplish? I saw that github has some kind of a ticket board (trello like), or maybe we use the discussions for that. Because sometimes I have so many ideas and want to write them down somewhere, I think that would help sync ourselves to common goals or to plan things better.

Sounds good, would be more helpful than syncing plans in MR comments. I think we had a discussion for such planning once, and this makes even more sense than that.

BTW: I love working on this project with you, always makes a lot of fun to see what we creating here :)

Thanks, the feeling is mutual, and I dare say it won't move even at a quarter of its current pace if it were not for you. I have a secret plan to up my Nix game this winter, so hope I'll be of more use after that.

Gerschtli · 2021-12-15T17:13:20Z

I agree, the way we handle releases is fine and communicated correctly.

I think we had a discussion for such planning once, and this makes even more sense than that.

So you are in favor of this board or of the discussions feature of github? I would be fine with both, I never worked with either of them.

Thanks, the feeling is mutual, and I dare say it won't move even at a quarter of its current pace if it were not for you. I have a secret plan to up my Nix game this winter, so hope I'll be of more use after that.

Thank you, sometimes it feels like I create multiple big PRs in a week and then a couple of months nothing, but you are always fast in regards of reviews and responses. Whatever "to up my Nix game" is but it sounds promising. Flakifying my whole setup was the motivation I needed to get my hands dirty again on this project :)

t184256 · 2021-12-15T20:37:17Z

Tried some fancy board thing, let's see how useful it is.

Gerschtli requested a review from t184256 December 5, 2021 15:31

Gerschtli force-pushed the release-21.11 branch from 5e9e1f8 to 510ca55 Compare December 5, 2021 16:37

t184256 mentioned this pull request Dec 8, 2021

pkgs/nix-directory: stop using qemu-user to init nix db #149

Merged

Gerschtli added 4 commits December 8, 2021 23:18

Remove deprecated workaround for make

3af7f09

Update stateVersions and channel versions to 21.11

dda1850

Remove workaround in default nix-on-droid config

e0d3e41

Workaround is with home-manager 21.11 no longer needed.

Release 21.11

c46cd12

t184256 force-pushed the release-21.11 branch from 510ca55 to 2810239 Compare December 8, 2021 22:27

Gerschtli and others added 3 commits December 9, 2021 20:57

Update pinned nixpkgs version

a1094c5

pkgs/cross-compiling/proot-termux: update

8bd2b07

Fix static cross compiling of proot

c727d5f

Gerschtli force-pushed the release-21.11 branch from 2810239 to 90ab04a Compare December 9, 2021 19:58

Gerschtli marked this pull request as ready for review December 9, 2021 19:59

Gerschtli force-pushed the release-21.11 branch from 90ab04a to 21afc02 Compare December 9, 2021 20:16

t184256 reviewed Dec 10, 2021

View reviewed changes

Gerschtli added 2 commits December 10, 2021 21:00

home-manager: remove support for 19.09 releases

bd2e734

session-init: add support for nix 2.4

843252c

See NixOS/nixpkgs#149791.

Gerschtli force-pushed the release-21.11 branch from ce95c44 to 843252c Compare December 10, 2021 20:01

t184256 reviewed Dec 10, 2021

View reviewed changes

modules/environment/login/nix-on-droid.nix.default Show resolved Hide resolved

nixpkgs: always provide the option definitions

379045d

This allows evaluation of configurations where nixpkgs.* options are used even when in a flake setup with unchanged default values.

Gerschtli force-pushed the release-21.11 branch from 8511636 to 379045d Compare December 10, 2021 23:37

Gerschtli mentioned this pull request Dec 11, 2021

WIP: On-device tests #146

Merged

t184256 approved these changes Dec 11, 2021

View reviewed changes

t184256 merged commit 8972fbf into nix-community:master Dec 11, 2021

Gerschtli deleted the release-21.11 branch December 11, 2021 22:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 21.11 #147

Release 21.11 #147

Gerschtli commented Dec 5, 2021

t184256 commented Dec 5, 2021

t184256 commented Dec 6, 2021

t184256 commented Dec 8, 2021

t184256 commented Dec 8, 2021

Gerschtli commented Dec 9, 2021

Gerschtli commented Dec 9, 2021

t184256 commented Dec 9, 2021

Gerschtli commented Dec 9, 2021

t184256 commented Dec 9, 2021

Gerschtli commented Dec 9, 2021

Gerschtli commented Dec 9, 2021

Gerschtli commented Dec 9, 2021

t184256 Dec 10, 2021

t184256 Dec 10, 2021

Gerschtli Dec 10, 2021

t184256 left a comment

Gerschtli commented Dec 12, 2021 •

edited

Loading

Gerschtli commented Dec 14, 2021

t184256 commented Dec 14, 2021

Gerschtli commented Dec 14, 2021

t184256 commented Dec 14, 2021

Gerschtli commented Dec 15, 2021

t184256 commented Dec 15, 2021

Release 21.11 #147

Release 21.11 #147

Conversation

Gerschtli commented Dec 5, 2021

t184256 commented Dec 5, 2021

t184256 commented Dec 6, 2021

t184256 commented Dec 8, 2021

t184256 commented Dec 8, 2021

Gerschtli commented Dec 9, 2021

Gerschtli commented Dec 9, 2021

t184256 commented Dec 9, 2021

Gerschtli commented Dec 9, 2021

t184256 commented Dec 9, 2021

Gerschtli commented Dec 9, 2021

Gerschtli commented Dec 9, 2021

Gerschtli commented Dec 9, 2021

t184256 Dec 10, 2021

Choose a reason for hiding this comment

t184256 Dec 10, 2021

Choose a reason for hiding this comment

Gerschtli Dec 10, 2021

Choose a reason for hiding this comment

t184256 left a comment

Choose a reason for hiding this comment

Gerschtli commented Dec 12, 2021 • edited Loading

Gerschtli commented Dec 14, 2021

t184256 commented Dec 14, 2021

Gerschtli commented Dec 14, 2021

t184256 commented Dec 14, 2021

Gerschtli commented Dec 15, 2021

t184256 commented Dec 15, 2021

Gerschtli commented Dec 12, 2021 •

edited

Loading