Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to nushell and drop gitpod #376

Merged
merged 9 commits into from
Nov 4, 2022
Merged

switch to nushell and drop gitpod #376

merged 9 commits into from
Nov 4, 2022

Conversation

colemickens
Copy link
Member

No description provided.

@colemickens colemickens force-pushed the dev branch 2 times, most recently from 29a2fb1 to d1568a8 Compare October 31, 2022 20:33
@Artturin
Copy link
Member

Artturin commented Oct 31, 2022 •
edited
Loading

Add nushell to devShells.default

@colemickens
Copy link
Member Author

I still need to fixup the README regeneration.

@colemickens
Copy link
Member Author

This also replaces nix-build-uncached with nix-eval-jobs.

@Artturin
Copy link
Member

Artturin commented Nov 1, 2022

https://github.com/nix-community/nixpkgs-wayland#development-guide should also be updated

@colemickens
Copy link
Member Author

the readme is annoying. using take until, skip until with the comment delimiters seemed promising but it drops newlines.

If I use ripgrep the same way, somehow it mangles a bunch of the text even with | save --raw ...

@Artturin
Copy link
Member

Artturin commented Nov 1, 2022 •
edited
Loading

readme generation in python #380 if preferred

@colemickens colemickens force-pushed the dev branch 3 times, most recently from d821a1a to 1e08183 Compare November 1, 2022 19:37
@colemickens
Copy link
Member Author

It wound up not being that bad, I think I'd made a silly mistake at first. I prefer this over the python version (dependencies, my general aversion to python, there's only one small sin being committed here using ripgrep, etc).

@colemickens
Copy link
Member Author

There's also some other small cleanups to the internals of the flake, reflecting some changes I'd made in my own config too.

Notably, I eliminated waylandPkgs from the overlay, and packages now invokes the overlay directly to produce its package set instead of using waylandPkgs. It also no longer includes the "linkFarmDrv" default package, because it makes it easier to let nix-eval-jobs be efficient.

Artturin
Artturin reviewed Nov 1, 2022
View reviewed changes
flake.nix Show resolved Hide resolved
@colemickens colemickens force-pushed the dev branch 8 times, most recently from 21c7312 to 3672497 Compare November 3, 2022 02:46
@colemickens
Copy link
Member Author

alright, I'm actually pretty happy with this.

@colemickens colemickens force-pushed the dev branch 3 times, most recently from d3b26b0 to 5ad07d3 Compare November 3, 2022 03:47
@colemickens
Copy link
Member Author

image

@colemickens
Copy link
Member Author

firefox did the best it could

@colemickens colemickens force-pushed the dev branch 4 times, most recently from 7cc5fdb to 53e6f06 Compare November 4, 2022 00:12
@Artturin
Copy link
Member

Artturin commented Nov 4, 2022

image

Looks good

@colemickens colemickens merged commit 3e0937a into nix-community:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artturin Artturin Artturin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemickens @Artturin