New bootstrap fixes #1290
New bootstrap fixes #1290
Conversation
K900
force-pushed
the
new-bootstrap-fixes
branch
from
697ee81 to
77678e6
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/psa-poetry2nix-is-currently-broken-with-nixpkgs-unstable/32281/1 |
| @@ -2760,14 +2760,6 @@ lib.composeManyExtensions [ | |||
| } | |||
| ); | |||
|
|
|||
|
|
|||
| # Stop infinite recursion by using bootstrapped pkg from nixpkgs | |||
There was a problem hiding this comment.
those using poerty2nix with python2 projects may want to keep this
|
I would be happy to help fix what's broken too. I should have checked this before merging, but I forgot. With that said, I might need some hand holding since I don't use poetry2nix. |
| "owner": "NixOS", | ||
| "repo": "nixpkgs", | ||
| "rev": "2de8efefb6ce7f5e4e75bdf57376a96555986841", | ||
| "rev": "f900e733c1602b4c46064a9ef0514bb2345a8949", |
There was a problem hiding this comment.
I would say this makes it "conditional on nixpkg version". Otherwise there is lib.version which is a string :/
|
What is the status of the fix? Do I need to include this patch if I want to use latest version of nixpkgs and poetry2nix? |
You'll want to follow #1291 which has more info and status updates. |
|
I really don't have the time or the spoons to invest into this anymore. Anyone interested in picking this up, please do. |
|
I'll just close the PR because I really don't intend to work on this any time soon. Anyone willing to pick up the work is more than welcome to. |
This gets things building, at least. We should probably figure out how to make these conditional on nixpkgs version though...